Introduce ColumnDataType to use as return type to ColumnSource#getType
#3455
Assignees
Labels
Milestone
Comments
nbauernfeind
changed the title
ColumnType to use as return type to ColumnSource#getTypeColumnDataType to use as return type to ColumnSource#getType
nbauernfeind
added a commit
to deephaven/web-client-ui
that referenced
this issue
Feb 28, 2023
deephaven/deephaven-core#3385 is a port of DH-11692 which adds `Instant` and `ZonedDateTime` support to the engine. I've similarly encoded these types over Barrage as a `long` (as a nanosecond since epoch). The encoding of Zones will actually need to be implemented at a future date as the best implementation requires (encourages?) a much larger refactoring of ColumnSource types. See deephaven/deephaven-core#3455 for more information. I was able to get the web-client-ui to display these types with this small patch.
nbauernfeind
added a commit
that referenced
this issue
Mar 3, 2023
DH-11692 via commits: - deephaven-ent/iris@563e69e - deephaven-ent/iris@f680b26 - deephaven-ent/iris@4f46299 - deephaven-ent/iris@7baba9f Follow up work: - Instant/LocalDate/LocalTime/ZonedDateTime support for Parquet, KafkaTools and JsonNodeUtil #3367 - ArraySource#move support moving of full blocks #3359 - Introduce ColumnDataType to use as return type to ColumnSource#getType #3455
|
Also see #3650. |
pete-petey
modified the milestones:
August 2023,
2023 tickets than need to be 'milestone-ed' and assigned
pete-petey
modified the milestones:
Year 2023 tickets that need to be 'milestone-ed' and assigned,
5. Backlog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
With the introduction of
ZonedDateTimecolumn type return types, it is very easy to lose theZoneId-- such as via agroupByand then anungroup.Similarly, it might be nice to have a way to maintain the original column type from Arrow sources. If we group/ungroup (and otherwise only affect ordering of rows) it might be expected that Barrage does not change the Arrow source column type. For example,
uint4get upgraded tolonginternally -- but we may prefer to senduint4to non-web-client subscribers.We could introduce a
ColumnDataTypetype to use instead ofClass<?>forColumnSource#getType.It is desirable to use the QST's Column Data Type as marrying the java client to the server has usability benefits. There is some design to work through w.r.t.
Instantas this is how the java client refers to server-side DateTime columns.The text was updated successfully, but these errors were encountered: