Skip to content

Commit

Permalink
UpdateGraph: Log Dependency Information On Failure to Proceed (#4980)
Browse files Browse the repository at this point in the history
  • Loading branch information
nbauernfeind authored Dec 22, 2023
1 parent 62be1d0 commit b1026ed
Showing 1 changed file with 10 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -574,6 +574,16 @@ private void flushNormalNotificationsAndCompleteCycle() {
}
}
if (outstandingCountAtStart == 0 && nothingBecameSatisfied) {
if (!printDependencyInformation) {
// Let's drop some breadcrumbs here, because this is a very bad state to be in and hard to debug.
log.error().append(Thread.currentThread().getName())
.append(": No outstanding notifications, yet notification queue size=")
.append(pendingToEvaluate.size()).endl();
for (final Notification notification : pendingToEvaluate) {
log.error().append(Thread.currentThread().getName()).append(": Unmet dependencies for ")
.append(notification).endl();
}
}
throw new IllegalStateException(
"No outstanding notifications, yet the notification queue is not empty!");
}
Expand Down

0 comments on commit b1026ed

Please sign in to comment.