Skip to content

Commit

Permalink
Move uri resolvers+wiring to uri (#1706)
Browse files Browse the repository at this point in the history
These classes are specific to uri but lived in grpc-api server packages. These could also end up in their own module just for reuse in other projects that want to register, expose their own set of resolvers, but the simplest refactor was to move to :java-client-uri.

Partial #1270
  • Loading branch information
niloc132 authored Dec 17, 2021
1 parent 3584cc7 commit 96211ec
Show file tree
Hide file tree
Showing 11 changed files with 30 additions and 12 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,11 @@
import io.deephaven.grpc_api.console.ConsoleServiceGrpcImpl;
import io.deephaven.grpc_api.log.LogInit;
import io.deephaven.grpc_api.session.SessionService;
import io.deephaven.grpc_api.uri.UriResolver;
import io.deephaven.grpc_api.uri.UriResolvers;
import io.deephaven.internal.log.LoggerFactory;
import io.deephaven.io.logger.Logger;
import io.deephaven.grpc_api.uri.UriResolversInstance;
import io.deephaven.uri.resolver.UriResolver;
import io.deephaven.uri.resolver.UriResolvers;
import io.deephaven.uri.resolver.UriResolversInstance;
import io.deephaven.util.annotations.VisibleForTesting;
import io.deephaven.util.process.ProcessEnvironment;
import io.deephaven.util.process.ShutdownManager;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
import io.deephaven.grpc_api.appmode.ApplicationStates;
import io.deephaven.uri.ApplicationUri;
import io.deephaven.uri.DeephavenUri;
import io.deephaven.uri.resolver.UriResolver;
import io.deephaven.uri.resolver.UriResolversInstance;

import javax.inject.Inject;
import java.net.URI;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@
import io.deephaven.uri.QueryScopeUri;
import io.deephaven.uri.RemoteUri;
import io.deephaven.uri.StructuredUri.Visitor;
import io.deephaven.uri.resolver.UriResolver;
import io.deephaven.uri.resolver.UriResolversInstance;
import io.grpc.ManagedChannel;
import org.apache.arrow.memory.BufferAllocator;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

import io.deephaven.csv.CsvTools;
import io.deephaven.engine.table.Table;
import io.deephaven.uri.resolver.UriResolver;
import io.deephaven.uri.resolver.UriResolversInstance;

import javax.inject.Inject;
import java.io.IOException;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
import io.deephaven.engine.table.Table;
import io.deephaven.parquet.table.ParquetTools;
import io.deephaven.uri.UriHelper;
import io.deephaven.uri.resolver.UriResolver;
import io.deephaven.uri.resolver.UriResolversInstance;

import javax.inject.Inject;
import java.net.URI;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
import io.deephaven.grpc_api.console.GlobalSessionProvider;
import io.deephaven.uri.DeephavenUri;
import io.deephaven.uri.QueryScopeUri;
import io.deephaven.uri.resolver.UriResolver;
import io.deephaven.uri.resolver.UriResolversInstance;

import javax.inject.Inject;
import java.net.URI;
Expand Down
12 changes: 12 additions & 0 deletions grpc-api/src/main/java/io/deephaven/grpc_api/uri/UriModule.java
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,14 @@

import dagger.Binds;
import dagger.Module;
import dagger.Provides;
import dagger.multibindings.IntoSet;
import io.deephaven.grpc_api.barrage.BarrageClientModule;
import io.deephaven.uri.resolver.UriResolver;
import io.deephaven.uri.resolver.UriResolvers;

import javax.inject.Singleton;
import java.util.Set;

/**
* Installs the {@link UriResolver URI resolvers}. See each specific resolver for more information.
Expand Down Expand Up @@ -36,4 +42,10 @@ public interface UriModule {
@Binds
@IntoSet
UriResolver bindParquetResolver(ParquetTableResolver resolver);

@Provides
@Singleton
static UriResolvers bindResolvers(Set<UriResolver> resolvers) {
return new UriResolvers(resolvers);
}
}
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package io.deephaven.uri;

import io.deephaven.grpc_api.uri.UriResolver;
import io.deephaven.grpc_api.uri.UriResolversInstance;
import io.deephaven.uri.resolver.UriResolver;
import io.deephaven.uri.resolver.UriResolversInstance;

import java.net.URI;

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package io.deephaven.grpc_api.uri;
package io.deephaven.uri.resolver;

import java.net.URI;
import java.util.Set;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
package io.deephaven.grpc_api.uri;
package io.deephaven.uri.resolver;

import javax.inject.Inject;
import javax.inject.Singleton;
import java.net.URI;
import java.util.Collections;
import java.util.HashMap;
Expand All @@ -13,13 +11,11 @@
import java.util.Set;
import java.util.stream.Collectors;

@Singleton
public final class UriResolvers {

private final Set<UriResolver> resolvers;
private final Map<String, Set<UriResolver>> map;

@Inject
public UriResolvers(Set<UriResolver> resolvers) {
this.resolvers = Objects.requireNonNull(resolvers);
map = new HashMap<>();
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package io.deephaven.grpc_api.uri;
package io.deephaven.uri.resolver;

import java.util.Objects;

Expand Down

0 comments on commit 96211ec

Please sign in to comment.