Move protoc-base to ubuntu based, to fix compatibility with cpp-client-base. #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinrsmith
added a commit
to devinrsmith/deephaven-core
that referenced
this pull request
Nov 9, 2023
Update some unit testing gradle wrapper versions to ensure gradle works with OpenJDK 21 deephaven/deephaven-server-docker#69 deephaven/deephaven-server-docker#70 Not updating cpp or protoc base, see deephaven/deephaven-base-images#102 deephaven#4805
This was referenced Nov 9, 2023
devinrsmith
added a commit
to deephaven/deephaven-core
that referenced
this pull request
Nov 10, 2023
Update some unit testing gradle wrapper versions to ensure inner-gradle works with OpenJDK 21 deephaven/deephaven-server-docker#69 deephaven/deephaven-server-docker#70 Not updating cpp or protoc base, see deephaven/deephaven-base-images#102 #4805
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cpp-client-base image had moved already to be ubuntu based, out of plans to factor out commonality with some dockerized builds on the DHE side: the plan is to use the cpp-client-base dockerfile from DHE to avoid duplication in DHE dockerized builds.
The issue that the PR that did that introduced, which Devin noticed (thanks!), is that this in the current protoc-base image:
triggers an issue because the plugin binary, being produced on ubuntu now, can't run in the debian-based protoc due to shared libraries incompatibilities: