Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lint] Add golangci-lint automation + fix existing issues #79

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

tomaszjonak
Copy link
Contributor

@tomaszjonak tomaszjonak commented Nov 20, 2023

When this PR lands I would like to toggle "green ci" as a mandatory requirement for further PR merges.

@tomaszjonak tomaszjonak force-pushed the tomasz/linters branch 2 times, most recently from 46b854f to 0e3c11b Compare November 20, 2023 15:38
pkg/runner/runner.go Outdated Show resolved Hide resolved
Copy link
Contributor

@noboruma noboruma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go after fatal addressed

@tomaszjonak tomaszjonak merged commit 2b81a19 into main Nov 21, 2023
1 check passed
@tomaszjonak tomaszjonak deleted the tomasz/linters branch November 21, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants