Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use-ticker: Use ticker instead of timer for periodic task #58

Merged
merged 1 commit into from
May 29, 2023
Merged

use-ticker: Use ticker instead of timer for periodic task #58

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pkg/jobs/status.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ func StartStatusReporter(ctx context.Context, scan_id string, scanner *scan.Scan

go func() {
defer stopScanJob()

ticker := time.NewTicker(30 * time.Second)
var err, abort error
ts := time.Now()
loop:
Expand All @@ -34,7 +34,7 @@ func StartStatusReporter(ctx context.Context, scan_id string, scanner *scan.Scan
break loop
case <-scanner.ScanStatusChan:
ts = time.Now()
case <-time.After(30 * time.Second):
case <-ticker.C:
elapsed := int(time.Since(ts).Seconds())
if elapsed > threshold {
err = fmt.Errorf("Scan job aborted due to inactivity")
Expand Down