added user list table in user management tab of settings #981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manV
requested changes
Apr 4, 2023
deepfence_frontend/apps/dashboard/src/features/settings/pages/ChangePassword.tsx
Outdated
Show resolved
Hide resolved
deepfence_frontend/apps/dashboard/src/features/settings/pages/actions/userAddAction.ts
Outdated
Show resolved
Hide resolved
deepfence_frontend/apps/dashboard/src/features/settings/pages/UserManagement.tsx
Show resolved
Hide resolved
deepfence_frontend/apps/dashboard/src/features/settings/pages/ChangePassword.tsx
Outdated
Show resolved
Hide resolved
deepfence_frontend/apps/dashboard/src/features/settings/pages/ChangePassword.tsx
Outdated
Show resolved
Hide resolved
manV
reviewed
Apr 4, 2023
deepfence_frontend/apps/dashboard/src/features/settings/pages/UserAdd.tsx
Outdated
Show resolved
Hide resolved
|
manV
requested changes
Apr 6, 2023
deepfence_frontend/apps/dashboard/src/features/settings/pages/ChangePassword.tsx
Outdated
Show resolved
Hide resolved
| import { ApiError, makeRequest } from '@/utils/api'; | ||
| import { typedDefer, TypedDeferredData } from '@/utils/router'; | ||
| import { DFAwait } from '@/utils/suspense'; | ||
| import { usePageNavigation } from '@/utils/usePageNavigation'; |
| label={'Status'} | ||
| placeholder="Active" | ||
| sizing="xs" | ||
| className="w-3/4 min-[200px] max-w-xs relative pl-3" |
There was a problem hiding this comment.
min-[200px] relative classes are probably not required.
| <p | ||
| className={`mt-1.5 w-3/4 min-[200px] max-w-xs ${Typography.size.sm} text-green-500`} | ||
| > | ||
| Invite URL:{data?.invite_url}, invite will expire after{' '} |
There was a problem hiding this comment.
lets have a copy button for ease of use.
manV
requested changes
Apr 6, 2023
manV
approved these changes
Apr 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # .
Changes proposed in this pull request:
@deepfence/engineering