Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On scan delete, set previous scan id on the nodes #2099

Merged
merged 7 commits into from
Apr 18, 2024
Merged

Conversation

ramanan-ravi
Copy link
Collaborator

@ramanan-ravi ramanan-ravi commented Apr 17, 2024

  • Separate functions to delete entire scan and partial scan results
  • When a scan is deleted, set previous scan id on the node if it was scanned before. Set empty otherwise.

@ramanan-ravi ramanan-ravi requested a review from noboruma April 17, 2024 17:46
Copy link
Collaborator

@noboruma noboruma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (after addressing comments)

@ramanan-ravi ramanan-ravi merged commit 5ec5c5b into main Apr 18, 2024
3 of 4 checks passed
@ramanan-ravi ramanan-ravi deleted the delete-scan branch April 18, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants