Support deleting cloud accounts #2060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnmahanth
force-pushed
the
delete-cloud-account
branch
from
514a9b9 to
e0414a6
Compare
ramanan-ravi
approved these changes
Apr 5, 2024
gnmahanth
force-pushed
the
delete-cloud-account
branch
from
e0414a6 to
3455664
Compare
gnmahanth
force-pushed
the
delete-cloud-account
branch
2 times, most recently
from
f49d5ec to
7f42076
Compare
noboruma
reviewed
Apr 9, 2024
Comment on lines
+166
to
+171
| // delete hosts discovered from cloud | ||
| deleteHostsQuery := ` | ||
| MATCH (n:Node{account_id: $node_id}) | ||
| WHERE n.agent_running=false | ||
| DETACH DELETE n | ||
| ` |
There was a problem hiding this comment.
I think we should not delete the Node directly and leave this job to the clean up task, there are couple of edge cases to be handled
Let's mark it as not running via:
MATCH (n:Node{account_id: $node_id})
SET n.agent_running=false
Instead
| } | ||
| } | ||
|
|
||
| h.AuditUserActivity(r, EventComplianceScan, ActionDelete, req, true) |
There was a problem hiding this comment.
I think auditlogs should be created even if the task fails.
we need a better framework at router level for auditlog, instrumenting all the methods with h.AuditUserActivity is overkill.(not scope of this PR)
gnmahanth
force-pushed
the
delete-cloud-account
branch
from
7f42076 to
c33c93f
Compare
ibreakthecloud
approved these changes
Apr 10, 2024
noboruma
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request: