(fix) make vulnerability node_id more unique #2045
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
package (p1),version(v1), package_path (pp1) : vuln(cve1)
package (p1), version(v1), package_path (pp2): vuln(cve1)
In this case we were dropping vulnerabilities.
Example:
Two vulnerability with same cve, same package, same version, but different package_path
Using ID with cve_id + package_name + package_version, might led to dropping of CVEs which we have observed recently.