update neo4j health check to consider database backup #2003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramanan-ravi
approved these changes
Mar 5, 2024
noboruma
reviewed
Mar 5, 2024
Comment on lines
+17
to
+24
| if [ "$NEO4J_OFFLINE_MAINTENANCE_MODE_ENABLED" = true ]; then | ||
| while true; | ||
| do | ||
| echo 'Neo4j is not running. Remove NEO4J_OFFLINE_MAINTENANCE_MODE_ENABLED env var or set offlineMaintenanceModeEnabled to false to resume normal operation.'; | ||
| sleep 60; | ||
| done | ||
| fi | ||
|
|
There was a problem hiding this comment.
I am not following - this is an infinite loop, right?
When do we need to do that? df.sh only runs 1 and should never stop
There was a problem hiding this comment.
This will be enabled when we want to some maintenance operations on neo4j itself, when set the database will not start also in this mode the kubernetes health check is disabled allowing us to operate on db when process is not running
similar kind of flag exists in standard neo4j helm chart
noboruma
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Changes proposed in this pull request: