Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data test id #1966

Merged
merged 1 commit into from
Feb 15, 2024
+18 −5
Merged

Add data test id #1966

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion deepfence_frontend/apps/dashboard/src/features/registries/pages/RegistryAccounts.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,7 +308,9 @@ const Header = () => {
</BreadcrumbLink>
</Breadcrumb>
<div className="ml-2 flex items-center">
{isFetching ? <CircleSpinner size="sm" /> : null}
{isFetching ? (
<CircleSpinner size="sm" data-testid="registryAccountSpinnerId" />
) : null}
</div>
</div>
);
Expand Down
2 changes: 1 addition & 1 deletion ...fence_frontend/apps/dashboard/src/features/topology/data-components/node-details/Host.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ export const Host = (props: HostModalProps) => {
<Suspense
fallback={
<div className="min-h-[300px] flex items-center justify-center dark:bg-bg-side-panel">
<CircleSpinner size="lg" />
<CircleSpinner size="lg" data-testid="nodeDetailsSpinnerId" />
</div>
}
>
Expand Down
4 changes: 3 additions & 1 deletion deepfence_frontend/apps/dashboard/src/features/vulnerabilities/pages/VulnerabilityScans.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1212,7 +1212,9 @@ const VulnerabilityScans = () => {
</BreadcrumbLink>
</Breadcrumb>
<div className="ml-2 flex items-center">
{isFetching ? <CircleSpinner size="sm" /> : null}
{isFetching ? (
<CircleSpinner size="sm" data-testid="scanListSpinnerId" />
) : null}
</div>
</div>

Expand Down
13 changes: 11 additions & 2 deletions deepfence_frontend/packages/ui-components/src/components/spinner/CircleSpinner.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,18 @@ const spinnerCVA = cva(['animate-spin dark:text-bg-side-panel fill-accent-accent
},
});

export const CircleSpinner = ({ size = 'md', className }: CircleSpinnerProps) => {
export const CircleSpinner = ({
size = 'md',
className,
...props
}: CircleSpinnerProps) => {
return (
<div className="inline-block bg-transparent" role="status">
<div
className="inline-block bg-transparent"
role="status"
data-testid="circularSpinnerId"
{...props}
>
<svg
aria-hidden="true"
className={cn(
Expand Down
Loading