[CI] golang linter configuration + bootstrapper fixes #1743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomaszjonak
force-pushed
the
tomasz/linters
branch
from
7f19847 to
be5aef0
Compare
noboruma
reviewed
Nov 21, 2023
Comment on lines
+19
to
+21
| ErrFailUpdate = errors.New("failed to update") | ||
| ErrFailCreate = errors.New("failed to create") | ||
| ErrCgroupNotExist = errors.New("cgroup does not exist") |
There was a problem hiding this comment.
I would rather keep error message starting with caps, easier to spot when embedded in other messages
There was a problem hiding this comment.
on the contrary. Golang usually goes with chaining in logging akin to err3: err2: err1 and actively encourages lowercase. On top of it if you include error messages within logs it may make sentences weird with sudden capitalization.
noboruma
reviewed
Nov 21, 2023
noboruma
reviewed
Nov 21, 2023
noboruma
reviewed
Nov 21, 2023
noboruma
approved these changes
Nov 21, 2023
tomaszjonak
force-pushed
the
tomasz/linters
branch
2 times, most recently
from
246163c to
b655305
Compare
tomaszjonak
force-pushed
the
tomasz/linters
branch
from
b655305 to
f7b16b1
Compare
tomaszjonak
pushed a commit
that referenced
this pull request
Nov 22, 2023
Fixes CI/build messed up by #1743
tomaszjonak
pushed a commit
that referenced
this pull request
Nov 22, 2023
Fixes CI/build messed up by #1743
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.