Posture counts #1653
Merged
Posture counts #1653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramanan-ravi
approved these changes
Oct 11, 2023
| @@ -237,9 +238,9 @@ func CachePostureProviders(ctx context.Context, task *asynq.Task) error { | |||
|
|
|||
| scan_count_query = ` | |||
| MATCH (n:` + string(neo4jNodeType) + `) | |||
| WHERE n.pseudo=false and n.active=true and n.agent_running=true | |||
There was a problem hiding this comment.
Is the condition n.agent_running=true not required for linux posture count too?
There was a problem hiding this comment.
hosts with agent_running=false are not allowed to scan so they will not appear here
deepfence_worker/ingesters/common.go
Outdated
| complete := false | ||
|
|
||
| for i := range data { | ||
| if data[i]["scan_status"].(string) == utils.SCAN_STATUS_SUCCESS { |
There was a problem hiding this comment.
Do we need to check if string conversion gave no error? Otherwise, might run into runtime error
There was a problem hiding this comment.
we dont need to check here as this field is guaranteed to have string data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Changes proposed in this pull request:
scan_countshould be number of accounts which are scanned irrespective of active or inactive accountsCachePostureProviderstask on detecting compliance scan success, this fixes the delay in sync of cached posture counts