Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix watermill middlewares not ack messages after processing #1533

Merged
merged 2 commits into from
Sep 8, 2023
Merged

fix watermill middlewares not ack messages after processing #1533

merged 2 commits into from
Sep 8, 2023

Conversation

gnmahanth
Copy link
Contributor

Fixes #

Changes proposed in this pull request:

  • fix watermill middlewares not ack messages after processing error cases
  • Enable retry of failed tasks if all retries fail message is acknowledge
  • if task panics the panic is captured and message is acknowledged

varunsharma0286
varunsharma0286 approved these changes Sep 8, 2023
View reviewed changes
Copy link
Contributor

@varunsharma0286 varunsharma0286 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

noboruma
noboruma reviewed Sep 8, 2023
View reviewed changes
deepfence_worker/worker.go Outdated Show resolved Hide resolved
noboruma
noboruma approved these changes Sep 8, 2023
View reviewed changes
Copy link
Collaborator

@noboruma noboruma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff, that's exactly what we needed

@noboruma noboruma merged commit dca986a into main Sep 8, 2023
@noboruma noboruma deleted the watermill-middlewares branch September 8, 2023 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramanan-ravi ramanan-ravi ramanan-ravi approved these changes

@noboruma noboruma noboruma approved these changes

@varunsharma0286 varunsharma0286 varunsharma0286 approved these changes

@ibreakthecloud ibreakthecloud Awaiting requested review from ibreakthecloud

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gnmahanth @noboruma @varunsharma0286 @ramanan-ravi