Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update to remember tab on return back #1389

Merged
merged 3 commits into from
Jul 21, 2023
Merged

update to remember tab on return back #1389

merged 3 commits into from
Jul 21, 2023
+98 −15

Conversation

milan-deepfence
Copy link
Contributor

@milan-deepfence milan-deepfence commented Jul 21, 2023 •
edited
Loading

@milan-deepfence milan-deepfence requested a review from manV as a code owner July 21, 2023 11:28
manV
manV reviewed Jul 21, 2023
View reviewed changes
deepfence_frontend/apps/dashboard/src/features/topology/components/NodeDetailsStackedModal.tsx Outdated
@@ -66,6 +76,8 @@ export const NodeDetailsStackedModal = ({
nodeId={lastNode.nodeId}
showBackBtn={showBackBtn}
onGoBack={onGoBack}
updateNodeInStack={updateNodeInStack}
lastVisitedTab={lastNode.lastVisitedTab}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can be renamed to defaultTab

deepfence_frontend/apps/dashboard/src/features/topology/components/NodeDetailsStackedModal.tsx Outdated
@@ -66,6 +76,8 @@ export const NodeDetailsStackedModal = ({
nodeId={lastNode.nodeId}
showBackBtn={showBackBtn}
onGoBack={onGoBack}
updateNodeInStack={updateNodeInStack}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can be renamed to onTabChange

deepfence_frontend/apps/dashboard/src/features/topology/components/NodeDetailsStackedModal.tsx Outdated
@@ -39,6 +40,13 @@ export const NodeDetailsStackedModal = ({
});
}, [stack]);

const updateNodeInStack = (lastVisitedTab: string) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe rename to setCurrentTab

@milan-deepfence milan-deepfence merged commit bb76828 into v2 Jul 21, 2023
@milan-deepfence milan-deepfence deleted the ui-v2-fix-node-stack-topology branch July 21, 2023 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manV manV manV approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@milan-deepfence @manV