UI v2 bug fixes #1353
Merged
UI v2 bug fixes #1353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manV
reviewed
Jul 18, 2023
| @@ -380,6 +380,16 @@ export const useIntegrationTableColumn = ( | |||
| }, | |||
| ), | |||
| ]; | |||
| case IntegrationType.email: | |||
| return [ | |||
| @@ -69,7 +69,7 @@ const Header = () => { | |||
| }; | |||
|
|
|||
| function processLabel(labelKey: string) { | |||
| return labelKey.replaceAll('_', ' ').replaceAll('id', 'ID'); | |||
| return labelKey.replaceAll('_', ' ').replace(new RegExp('\\bid', 'g'), 'ID'); | |||
There was a problem hiding this comment.
use functions instead of regex. see metadata.tsx in topology.
in the metadata.tsx also use === instead of .includes()
manV
reviewed
Jul 19, 2023
| @@ -68,8 +69,19 @@ const Header = () => { | |||
| ); | |||
| }; | |||
|
|
|||
| const UPPERCASE_WORDS = ['id']; | |||
There was a problem hiding this comment.
this we need to do in all node details modals.
There was a problem hiding this comment.
Yes we need in all details modals
manV
approved these changes
Jul 19, 2023
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
#1342
#1328 (comment)
#1333
#1349