separate clean up of host and registry images #1183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnmahanth
changed the title
noboruma
reviewed
May 31, 2023
deepfence_worker/cronjobs/neo4j.go
Outdated
Comment on lines
149
to
158
| // host images | ||
| if _, err = session.Run(` | ||
| MATCH (n:ContainerImage) | ||
| WHERE n.active = false | ||
| MATCH (n:ContainerImage) | ||
| WHERE exists((n)<-[:HOSTS]-(:Node)) | ||
| AND NOT exists((n)<-[:HOSTS]-(:RegistryAccount)) | ||
| AND n.active = false | ||
| AND NOT exists((n) <-[:SCANNED]-()) | ||
| OR n.updated_at < TIMESTAMP()-$old_time_ms | ||
| WITH n LIMIT 100000 | ||
| DETACH DELETE n`, | ||
| map[string]interface{}{ | ||
| "old_time_ms": dbScannedResourceCleanUpTimeout.Milliseconds(), | ||
| }); err != nil { | ||
| log.Error().Msgf("Error in Clean up DB task: %v", err) | ||
| return err | ||
| } | ||
|
|
||
| // registry images | ||
| if _, err = session.Run(` | ||
| MATCH (n:ContainerImage) | ||
| WHERE exists((n)<-[:HOSTS]-(:RegistryAccount)) | ||
| AND n.active = false | ||
| AND NOT exists((n) <-[:SCANNED]-()) |
There was a problem hiding this comment.
We don't need this because active = false is already holding the information (shall we delete the image or not)
gnmahanth
force-pushed
the
v2-images-cleanup
branch
from
37bee43 to
8b5c53f
Compare
gnmahanth
force-pushed
the
v2-images-cleanup
branch
from
8b5c53f to
5d49f42
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
@deepfence/engineering