Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed pagination issues #1122

Merged
merged 2 commits into from
May 24, 2023
Merged

Fixed pagination issues #1122

merged 2 commits into from
May 24, 2023

Conversation

manV
Copy link
Member

@manV manV commented May 23, 2023 •
edited
Loading

Changes proposed in this pull request:

  • Fixes an issue where deleting last page rows removes whole table and shows no data message
  • Fixes an issue where approximate pagination dots are shown if total rows are divisible by page size.
  • Fixes scan history deletion button disabled always

@manV manV requested a review from harishshg May 23, 2023 17:20
@manV manV marked this pull request as ready for review May 23, 2023 17:20
@manV manV requested a review from milan-deepfence as a code owner May 23, 2023 17:20
@manV manV merged commit 2d2ad2a into v2 May 24, 2023
@manV manV deleted the er-1746-1745 branch May 24, 2023 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harishshg harishshg harishshg approved these changes

@milan-deepfence milan-deepfence Awaiting requested review from milan-deepfence

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@manV @harishshg