fix: unescape url in registry sync and delete (#1571)

fix: unescape url in registry snc and delete
deepfence · Sep 14, 2023 · d09bdb6 · d09bdb6
1 parent 929d0dc
commit d09bdb6
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 2 deletions.
diff --git a/deepfence_server/handler/container_registry.go b/deepfence_server/handler/container_registry.go
@@ -455,7 +455,12 @@ func (h *Handler) AddGoogleContainerRegistry(w http.ResponseWriter, r *http.Requ
 }
 
 func (h *Handler) DeleteRegistry(w http.ResponseWriter, r *http.Request) {
-	id := chi.URLParam(r, "registry_id")
+	id, err := utils.URLDecode(chi.URLParam(r, "registry_id"))
+	if err != nil {
+		log.Error().Msgf("%v", err)
+		h.respondError(&BadDecoding{err}, w)
+		return
+	}
 
 	pgIds, err := model.GetRegistryPgIds(r.Context(), id)
 	if err != nil {
@@ -497,7 +502,12 @@ func (h *Handler) DeleteRegistry(w http.ResponseWriter, r *http.Request) {
 }
 
 func (h *Handler) RefreshRegistry(w http.ResponseWriter, r *http.Request) {
-	id := chi.URLParam(r, "registry_id")
+	id, err := utils.URLDecode(chi.URLParam(r, "registry_id"))
+	if err != nil {
+		log.Error().Msgf("%v", err)
+		h.respondError(&BadDecoding{err}, w)
+		return
+	}
 
 	pgIds, err := model.GetRegistryPgIds(r.Context(), id)
 	if err != nil {

diff --git a/deepfence_utils/utils/utils.go b/deepfence_utils/utils/utils.go
@@ -579,6 +579,10 @@ func URLEncode(s string) string {
 	return url.QueryEscape(s)
 }
 
+func URLDecode(s string) (string, error) {
+	return url.QueryUnescape(s)
+}
+
 func GetErrorRedirectUrl(consoleUrl, errorMessage string) string {
 	return consoleUrl + "/?errorMessage=" + URLEncode(errorMessage)
 }