Clouds scanner - start scan after cloud resources refresh is complete… #1871
ramanan-raviAnnotations
28 errors and 4 warnings
|
lint-server:
deepfence_server/pkg/constants/version.go#L17
S1025: the argument is already a string, there's no need to use fmt.Sprintf (gosimple)
|
|
lint-server:
deepfence_server/reporters/filter.go#L55
File is not `gofmt`-ed with `-s` (gofmt)
|
|
lint-server:
deepfence_server/pkg/integration/s3/types.go#L17
var `errAccountIDMissing` is unused (unused)
|
|
lint-server:
deepfence_server/diagnosis/console-diagnosis/kubernetes.go#L185
ineffectual assignment to ctx (ineffassign)
|
|
lint-server:
deepfence_server/controls/agent.go#L655
commentFormatting: put a space between `//` and comment text (gocritic)
|
|
lint-server:
deepfence_server/handler/export_reports.go#L462
ifElseChain: rewrite if-else to switch statement (gocritic)
|
|
lint-server:
deepfence_server/handler/export_reports.go#L498
ifElseChain: rewrite if-else to switch statement (gocritic)
|
|
lint-server:
deepfence_server/handler/license.go#L95
elseif: can replace 'else {if cond {}}' with 'else if cond {}' (gocritic)
|
|
lint-server:
deepfence_server/handler/license.go#L90
ifElseChain: rewrite if-else to switch statement (gocritic)
|
|
lint-server:
deepfence_server/pkg/registry/acr/client.go#L61
File is not `gofmt`-ed with `-s` (gofmt)
|
|
lint-utils:
deepfence_utils/directory/neo4j.go#L31
SA1019: neo4j.Config is deprecated: please use config.Config directly. This alias will be removed in 6.0. (staticcheck)
|
|
lint-utils:
deepfence_utils/controls/agent.go#L46
ST1003: should not use ALL_CAPS in Go names; use CamelCase instead (stylecheck)
|
|
lint-utils:
deepfence_utils/controls/agent.go#L145
ST1003: struct field ScanId should be ScanID (stylecheck)
|
|
lint-utils:
deepfence_utils/controls/agent.go#L146
ST1003: struct field AccountId should be AccountID (stylecheck)
|
|
lint-utils:
deepfence_utils/controls/agent.go#L152
ST1003: struct field AgentNodeId should be AgentNodeID (stylecheck)
|
|
lint-utils:
deepfence_utils/controls/agent.go#L158
ST1003: struct field Id should be ID (stylecheck)
|
|
lint-utils:
deepfence_utils/controls/agent.go#L164
ST1003: struct field NodeId should be NodeID (stylecheck)
|
|
lint-utils
issues found
|
|
lint-bootstrapper:
deepfence_bootstrapper/supervisor/process.go#L355
commentFormatting: put a space between `//` and comment text (gocritic)
|
|
lint-bootstrapper:
deepfence_bootstrapper/router/cloud_scanner.go#L117
Error return value of `conn.SetReadDeadline` is not checked (errcheck)
|
|
lint-bootstrapper:
deepfence_bootstrapper/router/cloud_scanner.go#L118
unslice: could simplify buf[:] to buf (gocritic)
|
|
lint-bootstrapper:
deepfence_bootstrapper/router/upgrade.go#L82
exitAfterDefer: log.Fatal will exit, and `defer os.Remove(dir)` will not run (gocritic)
|
|
lint-bootstrapper:
deepfence_bootstrapper/main.go#L133
commentFormatting: put a space between `//` and comment text (gocritic)
|
|
lint-bootstrapper:
deepfence_bootstrapper/main.go#L149
commentFormatting: put a space between `//` and comment text (gocritic)
|
|
lint-bootstrapper:
deepfence_bootstrapper/main.go#L49
ifElseChain: rewrite if-else to switch statement (gocritic)
|
|
lint-bootstrapper:
deepfence_bootstrapper/main.go#L39
var `binaryOnly` is unused (unused)
|
|
lint-bootstrapper:
deepfence_bootstrapper/router/cloud_scanner.go#L128
SA4004: the surrounding loop is unconditionally terminated (staticcheck)
|
|
lint-bootstrapper
issues found
|
|
lint-server
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2, actions/setup-go@v4, golangci/golangci-lint-action@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
lint-server
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
lint-utils
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-go@v4, golangci/golangci-lint-action@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
lint-bootstrapper
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-go@v4, golangci/golangci-lint-action@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|