Skip to content

Commit

Permalink
removing literal usage as python 3.7 doesn't support it
Browse files Browse the repository at this point in the history
  • Loading branch information
deepanker13 committed Jan 7, 2024
1 parent ec461a1 commit c27159b
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
2 changes: 0 additions & 2 deletions sdk/python/kubeflow/storage_init_container/hugging_face.py
Original file line number Diff line number Diff line change
@@ -1,10 +1,8 @@
from kubeflow.storage_init_container.abstract_model_provider import modelProvider
from kubeflow.storage_init_container.abstract_dataset_provider import datasetProvider
from dataclasses import dataclass, field
from typing import Literal
from urllib.parse import urlparse
import json, os
from typing import Dict, Any, Union
from datasets import load_dataset
from peft import LoraConfig
import transformers
Expand Down
4 changes: 2 additions & 2 deletions sdk/python/kubeflow/training/api/training_client.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
import logging
import time
import json
from typing import Optional, Callable, List, Dict, Any, Set, Literal, Union
from typing import Optional, Callable, List, Dict, Any, Set, Union
import queue
from kubernetes import client, config, watch

Expand Down Expand Up @@ -102,7 +102,7 @@ def train(
namespace: str = None,
num_workers: int = 1,
num_procs_per_worker: int = 1,
storage_config: Dict[Literal["size", "storage_class"], str] = {"size": "10Gi"},
storage_config: Dict[str, str] = {"size": "10Gi", "storage_class": None},
model_provider_parameters: HuggingFaceModelParams = None,
dataset_provider_parameters: Union[HfDatasetParams, S3DatasetParams] = None,
train_parameters: HuggingFaceTrainParams = None,
Expand Down

0 comments on commit c27159b

Please sign in to comment.