Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed example Button #143

Merged
merged 1 commit into from
Oct 30, 2019
Merged

Conversation

xzessmedia
Copy link

@xzessmedia xzessmedia commented Oct 12, 2019

According to this issue ( #137 ) , using stateless components apps bootstrapped with create-react-app ^3.0.0 will break this component.
This can be easily fixed by extending React.Component.
Added the correct sample to Readme.MD

@deepakaggarwal7
Copy link
Owner

Hey @xzessmedia xzessmedia! Thanks for helping with this fix. I'll merge it and publish it with tagging you in README very soon. Can you help me understand the exact problem it fixed? I mean is there any link to docs or something you can help to explain better on why exactly it is breaking now?

@xzessmedia
Copy link
Author

hi @deepakaggarwal7 please see the referenced issue.
most people bootstrapp their react apps with create-react-app.
the provided samplebutton is a stateless component which will result in the issue #137 when people use create-react-app ^3.0.0 after extending from React.Component class as described in the official react docs, it works.
If you have further questions, just let me now

@deepakaggarwal7 deepakaggarwal7 merged commit e52d1f3 into deepakaggarwal7:master Oct 30, 2019
@deepakaggarwal7
Copy link
Owner

Thanks. I've merged and would release a patch. Would credit you in README log :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants