Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] get github auth user id #112

Merged
merged 1 commit into from
Oct 12, 2018
Merged

[fix] get github auth user id #112

merged 1 commit into from
Oct 12, 2018

Conversation

Om4ar
Copy link
Contributor

@Om4ar Om4ar commented Jun 15, 2018

return the correct property to get the user id and move the login("username of github") to the name variable

deepakaggarwal7
deepakaggarwal7 approved these changes Oct 12, 2018
View reviewed changes
Copy link
Owner

@deepakaggarwal7 deepakaggarwal7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for integrating id. Will release a patch

@deepakaggarwal7 deepakaggarwal7 merged commit d3575f6 into deepakaggarwal7:master Oct 12, 2018
@deepakaggarwal7
Copy link
Owner

Is there any issue number which this fix maps with?

@Om4ar
Copy link
Contributor Author

Om4ar commented Oct 12, 2018 •
edited
Loading

@deepakaggarwal7 i think there is no issue reported but i had the issue my self

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepakaggarwal7 deepakaggarwal7 deepakaggarwal7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Om4ar @deepakaggarwal7