Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing react and bluebird from dependencies #140

Closed
jackyef opened this issue Sep 30, 2019 · 4 comments · Fixed by #155
Closed

Consider removing react and bluebird from dependencies #140

jackyef opened this issue Sep 30, 2019 · 4 comments · Fixed by #155

Comments

@jackyef
Copy link

jackyef commented Sep 30, 2019

By moving react and bluebird to peerDependencies, this package could shave around ~24kB in bundlesize gzip.

I am new to this package, but is there any reason for these to be included as react-social-login own dependencies?

For react, in most cases we can just depend on the consumer to bring their own react.
For bluebird, unless this package is using specific method that aren't in the official Promise spec yet, we can rely on the consumer to polyfill their own Promise.

@thiago-soliveira
Copy link

I agree with this. Specially when things like this happens.

@wattazoum
Copy link
Contributor

@thiago-soliveira I imagine that, the fact that you are pointing this error out means that you got it on your project. Did you find a solution for that ?

@thiago-soliveira
Copy link

@wattazoum I did. I used yarn resolutions to fix this.

deepakaggarwal7 added a commit that referenced this issue May 7, 2020
…-peer

#140 Move react and blueprint dependencies to peer
@deepakaggarwal7
Copy link
Owner

I've removed the bluebird need altogether and saw a whopping reduction from 120kb to 40KB.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants