-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider removing react and bluebird from dependencies #140
Comments
I agree with this. Specially when things like this happens. |
@thiago-soliveira I imagine that, the fact that you are pointing this error out means that you got it on your project. Did you find a solution for that ? |
wattazoum
added a commit
to wattazoum/react-social-login
that referenced
this issue
Mar 24, 2020
@wattazoum I did. I used yarn resolutions to fix this. |
deepakaggarwal7
added a commit
that referenced
this issue
May 7, 2020
…-peer #140 Move react and blueprint dependencies to peer
I've removed the bluebird need altogether and saw a whopping reduction from 120kb to 40KB. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
By moving
react
andbluebird
topeerDependencies
, this package could shave around ~24kB in bundlesize gzip.I am new to this package, but is there any reason for these to be included as
react-social-login
own dependencies?For
react
, in most cases we can just depend on the consumer to bring their ownreact
.For
bluebird
, unless this package is using specific method that aren't in the officialPromise
spec yet, we can rely on the consumer to polyfill their ownPromise
.The text was updated successfully, but these errors were encountered: