Replaces Travis with Github Action #465
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| name: Go lint | ||
|
|
||
| on: | ||
| push: | ||
| branches: [ master ] | ||
| pull_request: | ||
|
|
||
| jobs: | ||
|
|
||
| lint: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Use go >= 1.13 | ||
| uses: actions/setup-go@v3 | ||
| with: | ||
| go-version: '>=1.13' | ||
|
|
||
| - name: Check out code into the Go module directory | ||
| uses: actions/checkout@v3 | ||
|
|
||
| - name: Tidy | ||
| run: go mod tidy && [ -z "$(git status -s)" ] | ||
|
|
||
| - name: Lint | ||
| run: make lint | ||
|
|
||
| - name: Vet | ||
| run: make vet | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,64 @@ | ||
| name: Go test | ||
|
|
||
| on: | ||
| push: | ||
|
There was a problem hiding this comment. same as above - you can remove |
||
| branches: [ master ] | ||
| pull_request: | ||
|
|
||
| jobs: | ||
|
|
||
| test: | ||
| strategy: | ||
| matrix: | ||
| platform: [ubuntu-latest, macos-latest, windows-latest] | ||
|
|
||
| runs-on: ${{matrix.platform}} | ||
|
|
||
| steps: | ||
| - name: Use go >= 1.13 | ||
| uses: actions/setup-go@v3 | ||
| with: | ||
| go-version: '>=1.13' | ||
|
|
||
| - name: Check out code into the Go module directory | ||
| uses: actions/checkout@v3 | ||
|
|
||
| - name: Test with coverage | ||
| if: matrix.platform == 'ubuntu-latest' | ||
| run: go test -json -covermode=count -coverprofile=profile.cov ./... > report.json | ||
|
|
||
| - name: Test without coverage | ||
| if: matrix.platform == 'macos-latest' || matrix.platform == 'windows-latest' | ||
| run: go test ./... | ||
|
|
||
| - name: Sonarcloud scan | ||
| if: matrix.platform == 'ubuntu-latest' | ||
| uses: sonarsource/sonarcloud-github-action@master | ||
| with: | ||
| args: > | ||
| -Dsonar.organization=dedis | ||
| -Dsonar.projectKey=dedis_kyber | ||
| -Dsonar.go.tests.reportPaths=report.json | ||
| -Dsonar.go.coverage.reportPaths=profile.cov | ||
| -Dsonar.c.file.suffixes=- | ||
| -Dsonar.cpp.file.suffixes=- | ||
| -Dsonar.objc.file.suffixes=- | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }} | ||
|
|
||
| - name: Send coverage | ||
| if: matrix.platform == 'ubuntu-latest' | ||
| uses: shogo82148/actions-goveralls@v1 | ||
| with: | ||
| path-to-profile: profile.cov | ||
| parallel: true | ||
|
|
||
| # notifies that all test jobs are finished. | ||
| finish: | ||
| needs: test | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: shogo82148/actions-goveralls@v1 | ||
| with: | ||
| parallel-finished: true | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,13 @@ | ||
| lint: | ||
| # Coding style static check. | ||
| @go install honnef.co/go/tools/cmd/staticcheck@latest | ||
| @go mod tidy | ||
| #staticcheck `go list ./...` | ||
|
There was a problem hiding this comment. Do you want to put the staticcheck in its own target? That would make more sense, IMO. There was a problem hiding this comment. I prefer having one target that gathers all vetting scripts. Except if there is a case where we need to launch staticcheck but not the other linting tools. |
||
|
|
||
| vet: | ||
| go vet ./... | ||
|
|
||
| # target to run all the possible checks; it's a good habit to run it before | ||
| # pushing code | ||
| check: lint vet | ||
| go test ./... | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,4 @@ | ||
| //go:build experimental | ||
| // +build experimental | ||
|
|
||
| package curve25519 | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,4 @@ | ||
| //go:build experimental | ||
| // +build experimental | ||
|
|
||
| package curve25519 | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,4 @@ | ||
| //go:build (amd64 && !generic) || (arm64 && !generic) | ||
| // +build amd64,!generic arm64,!generic | ||
|
|
||
| package bn256 | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,4 @@ | ||
| //go:build (!amd64 && !arm64) || generic | ||
| // +build !amd64,!arm64 generic | ||
|
|
||
| package bn256 | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't use the
pushentry here, but rather protect the repository against direct pushes tomaster(which should be renamed tomain:) and only allow merges when the tests pass.This avoids running an unnecessary lint when you merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe redundant in some cases, but it doesn't hurt. I feel safer having a second check :)