multi: Update revoked tickets to expired/missed. #415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Any tickets in the database which are currently revoked should be updated to either expired or missed. This is achieved with a heuristic based on the expiry height and revoke height of the tickets. It is not guaranteed to be 100% correct but should be pretty close. The web api is not yet updated to reflect this change, missed/expired tickets will continue to be counted as revoked.
jholdstock
commented
Aug 26, 2023
| return nil | ||
| } | ||
|
|
||
| v.log.Warnf("Updating %s in revoked status, this may take a while...", |
There was a problem hiding this comment.
Adding context for "this may take a while", on my testnet VSP
[WRN] VSP: Updating 231 tickets in revoked status, this may take a while...
[DBG] VSP: Scanning 109113 blocks for 231 spent tickets
[INF] VSP: Took 36.742324728s
davecgh
approved these changes
Aug 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any tickets in the database which are currently revoked should be updated to either expired or missed.
This is achieved with a heuristic based on the expiry height and revoke height of the tickets. It is not guaranteed to be 100% correct but should be pretty close.
The web api is not yet updated to reflect this change, missed/expired tickets will continue to be counted as revoked.
Contributes to #268