Reject reused or old timestamps. #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnldd
reviewed
Dec 22, 2020
webapi/errors.go
Outdated
| @@ -107,6 +110,8 @@ func (e apiError) defaultMessage() string { | |||
| return "fee transaction could not be broadcast" | |||
| case errCannotBroadcastFeeUnknownOutputs: | |||
| return "fee transaction could not be broadcast due to unknown outputs" | |||
| case errInvalidTimestamp: | |||
| return "request timestamp is not newer than all previous requests" | |||
There was a problem hiding this comment.
s / request timestamp is not newer than all previous requests / request timestamp is older than the last request
There was a problem hiding this comment.
Hm, your suggestion isnt quite accurate, but I take your point. I will update the message
dnldd
approved these changes
Dec 23, 2020
dajohi
approved these changes
Dec 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14