Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc: Add methods #73

Merged
merged 4 commits into from
Feb 17, 2020
Merged

rpc: Add methods #73

merged 4 commits into from
Feb 17, 2020

Conversation

JoeGruffins
Copy link
Member

closes #45

  • addnode
  • createrawssrtx
  • createrawsstx
  • createrawtransaction
  • debuglevel
  • decoderawtransaction
  • decodescript
  • estimatefee
  • estimatesmartfee
  • estimatestakediff

The create raw transactions may not be perfect yet. I'm looking into it.

@JoeGruffins JoeGruffins force-pushed the clientmethods7 branch 3 times, most recently from 35ef529 to 2c3e6d6 Compare February 13, 2020 07:06
 - addnode
 - createrawssrtx
 - createrawsstx
 - createrawtransaction
 - debuglevel
 - decoderawtransaction
 - decodescript
 - estimatefee
 - estimatesmartfee
 - estimatestakediff
@JoeGruffins JoeGruffins marked this pull request as ready for review February 13, 2020 08:53
@JoeGruffins
Copy link
Member Author

dcrd must be build from master for tests to pass.

@buck54321
Copy link
Member

dcrd must be build from master for tests to pass.

Could you point out what's changing? TD should be compatible with the latest dcrd release, but we a have a little wiggle room right now.

@JoeGruffins
Copy link
Member Author

The inputs for a ticket purchase weren't being set as expected in dcrd. The tests compare a ticket purchase constructed with txscript against the response from the dcrd call createrawsstx. I can add a line to make sure the amount is correct that can be removed at some point.

decred/dcrd@6d8c54e

@JoeGruffins
Copy link
Member Author

Setting the value as expected inside the rpc call.

decred/decred/dcr/rpc.py Outdated Show resolved Hide resolved
decred/decred/dcr/rpc.py Show resolved Hide resolved
decred/decred/dcr/rpc.py Show resolved Hide resolved
decred/decred/dcr/rpc.py Outdated Show resolved Hide resolved
decred/decred/dcr/rpc.py Outdated Show resolved Hide resolved
decred/decred/dcr/rpc.py Outdated Show resolved Hide resolved
decred/decred/dcr/rpc.py Outdated Show resolved Hide resolved
decred/decred/dcr/rpc.py Show resolved Hide resolved
decred/decred/dcr/rpc.py Show resolved Hide resolved
decred/decred/dcr/wire/msgtx.py Outdated Show resolved Hide resolved
Expand one word descriptions. Fix spellings. Add Args: labels. Add
satsToCoins helper.
Copy link
Member

@buck54321 buck54321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple more things.

decred/decred/util/helpers.py Outdated Show resolved Hide resolved
decred/decred/dcr/rpc.py Outdated Show resolved Hide resolved
decred/decred/dcr/rpc.py Outdated Show resolved Hide resolved
decred/decred/dcr/rpc.py Outdated Show resolved Hide resolved

Returns:
float: Estimated fee.
int: Estimated fee in atoms/kb.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll note that I would prefer atoms/B, but atoms/kB is the unit used for the DefaultRelayFeePerKb constant in both TD and dcrwallet, so I think we should standardize on that.

@buck54321 buck54321 merged commit 753b326 into decred:master Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Finish the RPC client
2 participants