-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rpc: Add methods #73
rpc: Add methods #73
Conversation
35ef529
to
2c3e6d6
Compare
- addnode - createrawssrtx - createrawsstx - createrawtransaction - debuglevel - decoderawtransaction - decodescript - estimatefee - estimatesmartfee - estimatestakediff
2c3e6d6
to
92ce74f
Compare
dcrd must be build from master for tests to pass. |
Could you point out what's changing? TD should be compatible with the latest dcrd release, but we a have a little wiggle room right now. |
The inputs for a ticket purchase weren't being set as expected in dcrd. The tests compare a ticket purchase constructed with txscript against the response from the dcrd call createrawsstx. I can add a line to make sure the amount is correct that can be removed at some point. |
Setting the value as expected inside the rpc call. |
Expand one word descriptions. Fix spellings. Add Args: labels. Add satsToCoins helper.
00302ed
to
c0da39e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple more things.
|
||
Returns: | ||
float: Estimated fee. | ||
int: Estimated fee in atoms/kb. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll note that I would prefer atoms/B, but atoms/kB is the unit used for the DefaultRelayFeePerKb
constant in both TD and dcrwallet, so I think we should standardize on that.
closes #45
The create raw transactions may not be perfect yet. I'm looking into it.