multi: Add accountless ticket purchasing #22
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeGruffins
commented
Nov 26, 2019
pydecred/vsp.py
Outdated
| @@ -140,6 +150,8 @@ def __init__(self, url, apiKey): | |||
| # The signingAddress (also called a votingAddress in other contexts) is | |||
| # the P2SH 1-of-2 multi-sig address that spends SSTX outputs. | |||
| self.signingAddress = None | |||
| self.isAccountless = isAccountless | |||
| self.ID = ID | |||
There was a problem hiding this comment.
using an incremented id to track pools, rather than the api key, as accountless has none
JoeGruffins
commented
Nov 26, 2019
| """ | ||
| self.app.appWindow.pop(self) | ||
| self.poolScreen.isAccountless = True | ||
| self.poolScreen.refreshAccountless() | ||
| self.app.appWindow.stack(self.poolScreen) |
There was a problem hiding this comment.
these click events are tricky, wasn't sure how to pass a variable, so made a separate event for accountless, though seems wasteful
JoeGruffins
commented
Nov 26, 2019
| if len(self.stakePools) > 0: | ||
| pool.ID = max([p.ID for p in self.stakePools]) + 1 | ||
| self.stakePools = [pool] + [p for p in self.stakePools if p.ID != | ||
| pool.ID] |
There was a problem hiding this comment.
Separated add and set because accountless should have different data to set each time we buy a ticket whenever we start to derive a new address for every ticket.
JoeGruffins
force-pushed
the
accountlesspurchase
branch
from
b13d838
to
349da8c
Compare
When connecting to dcrdata, pull down the current agendas for use when voting.
Add a screen to show current agendas and a dropdown menu to choose how to vote.
Save a reference to the drowdown in the function that fires when activated. Move agendasInfo back to dcrdata blockchain.
If a vsp has APIVersionsSupported 3 allow accountless ticket purchasing for that pool.
JoeGruffins
force-pushed
the
accountlesspurchase
branch
from
349da8c
to
a302fec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on #7, #18
closes #16
Together with the api/purchaseticket endpoint, allows for ticket purchases without creating an account.
see: decred/dcrstakepool#515
pr 515 there is currently running on my testnet vsp at www.dcrstakedinner.com, that vsp has also been hardcoded into the list of vsp's
Right now, the same address is used for every request, but we could easily use a new one for every ticket, which would make tracking user tickets much more difficult.
screens