Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto: GCS filters #149

Merged
merged 5 commits into from
Apr 4, 2020
Merged

crypto: GCS filters #149

merged 5 commits into from
Apr 4, 2020

Conversation

buck54321
Copy link
Member

@buck54321 buck54321 commented Mar 31, 2020

Adds basic GCS filter. Filters can be decoded from bytes, but not created from scratch (not sure we'll even need it). I think will need a newFilter method to resolve conflicts among peers. Will follow up.

The bits parameter and false positive rate are not variables. They are package constants set to B=19 and M=784931, which are the values used by Decred.

Copy link
Member

@JoeGruffins JoeGruffins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heavy stuff.

decred/decred/crypto/gcs.py Outdated Show resolved Hide resolved
decred/decred/crypto/gcs.py Outdated Show resolved Hide resolved
Adds basic GCS filter support. Filters can be decoded from bytes,
but not created from scratch yet (not sure we'll even need it).

The bits parameter and false positive rate are not variables. They
are package constants set to B=19 and M=784931, which are the values
used by Decred.
@buck54321 buck54321 merged commit f0f3a0a into decred:master Apr 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants