-
Notifications
You must be signed in to change notification settings - Fork 14
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Stop the build from failing when a C compiler cannot be found.
- Loading branch information
Showing
1 changed file
with
23 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I want to catch any exception from
Cython
, including from it's functions likecythonize
. There should be no reasonCython
causes our install to fail ever, so I don't really care where the exception is happening inCython
, and I'm not going to try to predict where a failure will occur when the environment is wrong. If we have an issue withCython
, it should fall back to pure-Python. This is part of the reason I'm saying that the use ofelse:
is not appropriate here. It's like saying that it's okay to fail in some places but not others. It should fail gracefully regardless of where the exception actually occurs.