Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multi: Add proposal details page. #2723

Merged
merged 63 commits into from
Apr 29, 2022

Conversation

victorgcramos
Copy link
Member

@victorgcramos victorgcramos commented Feb 15, 2022

This PR adds the Proposal Details page, including all common-ui
components, and all core methods required for fetching proposal
details.

  • core:
    • Add Record Details thunk
    • Add Record details utils
  • common-ui:
    • Add LabelValueList component
    • Add RecordToken component
  • pi:
    • Proposal Details component
    • Common proposal components
    • /record/:token endpoint to render Proposal Details page

UI changes

Screen Shot 2022-02-15 at 2 23 19 PM

TODO:

Dependencies

@victorgcramos
Copy link
Member Author

Preview Update:

Screen Shot 2022-03-31 at 5 03 01 PM

@victorgcramos victorgcramos changed the title [WIP] multi: Add proposal details page. multi: Add proposal details page. Apr 27, 2022
@victorgcramos victorgcramos marked this pull request as ready for review April 27, 2022 23:10
@victorgcramos
Copy link
Member Author

Preview:

Screen Shot 2022-04-28 at 5 25 54 PM

Copy link
Member

@tiagoalvesdulce tiagoalvesdulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Great job!

Two small details:

  1. The user link isn't working on proposals list and proposal details.
  2. When a proposal is already cached and you navigate to it from the proposals list the scroll height from the home page is being persisted to the details page. Ideally it would go back to the top in the details page but keep it for the home page list if the user navigate back.

@tiagoalvesdulce tiagoalvesdulce merged commit 0fea662 into decred:master Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants