-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
multi: Add proposal details page. #2723
Merged
tiagoalvesdulce
merged 63 commits into
decred:master
from
victorgcramos:pi/proposal-details
Apr 29, 2022
Merged
multi: Add proposal details page. #2723
tiagoalvesdulce
merged 63 commits into
decred:master
from
victorgcramos:pi/proposal-details
Apr 29, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victorgcramos
changed the title
[WIP] multi: Add proposal details page.
multi: Add proposal details page.
Apr 27, 2022
tiagoalvesdulce
approved these changes
Apr 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Great job!
Two small details:
- The user link isn't working on proposals list and proposal details.
- When a proposal is already cached and you navigate to it from the proposals list the scroll height from the home page is being persisted to the details page. Ideally it would go back to the top in the details page but keep it for the home page list if the user navigate back.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the Proposal Details page, including all common-ui
components, and all core methods required for fetching proposal
details.
/record/:token
endpoint to render Proposal Details pageUI changes
TODO:
Dependencies