feat: add message to warn user about draft issues #2500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think this should be a tooltip. People won't see it until they go to save the draft, which is too late a lot of the time. I think this should be some type of banner. @tiagoalvesdulce thoughts? |
|
what about that, @lukebp? |
|
That's not really going to be noticable. We want to prevent the user from writing their proposal in the markdown editor. It needs to be very apparent to somebody starting to write a new proposal. |
|
maybe this?
|
|
I like that a lot. |
victorgcramos
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This diff closes #2496 by adding the warning on
DraftSavercomponent.UI Changes Screenshot