Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: display placeholders while loading initial records batch #2484

Merged
merged 1 commit into from
Jul 21, 2021

Conversation

victorgcramos
Copy link
Member

This diff fixes #2471 by adding the initial value for placeholders according to given pageSize argument. Default is set to PROPOSAL_PAGE_SIZE, which is 5.

UI Changes Screenshot

before:
Screen Shot 2021-07-20 at 7 27 59 PM

after:
Screen Shot 2021-07-20 at 7 25 51 PM

Copy link
Member

@tiagoalvesdulce tiagoalvesdulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@tiagoalvesdulce tiagoalvesdulce merged commit 7309ee4 into decred:master Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loading placeholders not displayed before initial records batch
2 participants