Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pi/proposal-edit] test: add e2e tests for proposal edit #2227

Merged
merged 2 commits into from
Dec 17, 2020
Merged

[pi/proposal-edit] test: add e2e tests for proposal edit #2227

merged 2 commits into from
Dec 17, 2020

Conversation

victorgcramos
Copy link
Member

@victorgcramos victorgcramos commented Nov 30, 2020 •
edited
Loading

This diff adds e2e tests for Proposal Edit:

Test cases:

  • Can edit a public proposal as a proposal owner
  • Can't edit a proposal if not the owner
  • Can't edit an authorized voting proposal
  • Can't edit without making description changes
  • Can't edit without making title changes

Reference issue: #2229

@victorgcramos victorgcramos marked this pull request as draft November 30, 2020 20:49
@victorgcramos victorgcramos changed the title [wip] [pi/proposal-edit] test: add e2e tests for proposal edit [pi/proposal-edit] test: add e2e tests for proposal edit Dec 1, 2020
@victorgcramos victorgcramos marked this pull request as ready for review December 1, 2020 23:52
tiagoalvesdulce
tiagoalvesdulce approved these changes Dec 17, 2020
View reviewed changes
Copy link
Member

@tiagoalvesdulce tiagoalvesdulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tiagoalvesdulce tiagoalvesdulce merged commit 814fff7 into decred:master Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiagoalvesdulce tiagoalvesdulce tiagoalvesdulce approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@victorgcramos @tiagoalvesdulce