Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments flat mode #1781

Merged
merged 16 commits into from
Feb 19, 2020
Merged

Comments flat mode #1781

merged 16 commits into from
Feb 19, 2020

Conversation

amass01
Copy link
Member

@amass01 amass01 commented Feb 15, 2020

This PR adds comments flat display mode, as described in #1209 - in order to make it easier for users to read all new comments without the struggle caused by the comments nested/tree structure.

Closes #1209

@amass01 amass01 marked this pull request as ready for review February 16, 2020 17:33
src/containers/Comments/Comment/Comment.jsx Outdated Show resolved Hide resolved
src/containers/Comments/Comment/CommentWrapper.jsx Outdated Show resolved Hide resolved
src/containers/Comments/Comment/CommentWrapper.jsx Outdated Show resolved Hide resolved
Copy link
Member Author

@amass01 amass01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tiagoalvesdulce Addressed

@tiagoalvesdulce
Copy link
Member

tiagoalvesdulce commented Feb 18, 2020

Looking pretty good. But some sorting options are unresponsive. Can you take a look? Here it works just fine after a refresh but until a refresh is made the sort is messed up. See:

top

"comentario c" should be on top of "comentario d".

@amass01
Copy link
Member Author

amass01 commented Feb 19, 2020

@tiagoalvesdulce Nice catch, I could reproduce it - the issue was that the sort/rank of comments wasn't updated on comment like event.
I've dispatched a sort action on like events, which should handle the case properly.

@tiagoalvesdulce
Copy link
Member

IMO the "re-sorting" on comment like isn't looking good. It's weird to vote on a comment and see it jumping to another place. Can you remove the dispatch in the handleCommentLike handler and keep it in the handleCommentsModeToggle handler?

@amass01
Copy link
Member Author

amass01 commented Feb 19, 2020

@tiagoalvesdulce agree, it's bad UX, changing it.

@tiagoalvesdulce tiagoalvesdulce merged commit 46e80f7 into decred:master Feb 19, 2020
@amass01 amass01 deleted the flatComments branch February 22, 2020 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "NEW FLAT" comment display mode
2 participants