[WIP] Add Decred plugin. #212
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sndurkin
suggested changes
Jan 20, 2018
politeiad/api/v1/v1.go
Outdated
| type Plugin struct { | ||
| ID string `json:"id"` // Identifier | ||
| Version string `json:"version"` // Version | ||
| Settings []PluginSetting `json:"setting"` // Settings |
There was a problem hiding this comment.
I think this should be "settings".
| ID string `json:"id"` // Plugin identifier | ||
| Command string `json:"command"` // Command identifier | ||
| CommandID string `json:"commandid"` // User setable command identifier | ||
| Payload string `json:"payload"` // Actual command reply |
There was a problem hiding this comment.
Does the reply need to include ID, Command and CommandID if the client already has that info?
There was a problem hiding this comment.
Yes, there can be multiple plugins.
politeiad/backend/backend.go
Outdated
| // Obtain plugin settings | ||
| GetPlugins() ([]Plugin, error) | ||
|
|
||
| // Pligin pass-through command |
politeiad/backend/gitbe/gitbe.go
Outdated
| @@ -2122,6 +2122,23 @@ func (g *gitBackEnd) Inventory(vettedCount, branchCount uint, includeFiles bool) | |||
| return pr, br, nil | |||
| } | |||
|
|
|||
| // GetPlugins returns the decred plugin settings. | |||
There was a problem hiding this comment.
This doc should probably be more generic, like "GetPlugins returns a list of currently supported plugins and their settings."
marcopeereboom
force-pushed
the
plugin
branch
2 times, most recently
from
86065b0 to
5087dcf
Compare
marcopeereboom
force-pushed
the
plugin
branch
3 times, most recently
from
2f0e357 to
a9cd8c9
Compare
marcopeereboom
force-pushed
the
plugin
branch
from
078fecd to
160b7b1
Compare
inventory is a mess; start recreating it using a map but keep old one in place for now flesh out api some more genericize md decoding convert comments to use new inventory decode voting add changes metadata
remove b.inventory and annotate areas that need fixup fuck you rebase
* Fix some issues with _inventory cache with unit tests. * Fix several unit tests that are broken from refactoring inventory. * Fix the rest of the failing www tests.
…n the right status before proceeding
… through expected failures and success
…, help from jrick
|
Finished in #242 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.