mysql: Fix InsertUser identity bug. #1635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a bug in the InsertUser function of the mysql user database implementation. When a new user record is inserted into the database, both the users table and the identities table must be updated. The InsertUser function was not updating the identities table, which was causing user by public key lookups to fail. The InsertUser function is only used during database migrations. This bug does not impact regular politeia use. This bug was introduce by 0b1982a.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug in the InsertUser function of the mysql user database
implementation.
When a new user record is inserted into the database, both the users
table and the identities table must be updated. The InsertUser function
was not updating the identities table, which was causing user by public
key lookups to fail.
The InsertUser function is only used during database migrations. This
bug does not impact regular politeia use.
This bug was introduce by 0b1982a.