politeiavoter: Add hoursprior config setting. #1542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. Some documenation explaining why it uses 12 hours prior to the end of the voting period would be helpful. |
marcopeereboom
force-pushed
the
lessthan12
branch
2 times, most recently
from
edc78ab to
5bc80ce
Compare
During poor network connections (e.g. when using tor) failed votes stack up over time. That combined with an aggressive end time (originally 1 hour prior to vote being complete) can lead to clustering or failed votes towards the end. This adds a new configuration option called --hoursprior. That value designates the hours to subtract from the end of the voting period and is set to a default of 12 hours. These extra hours prior to expiration gives the user some additional margin to correct failures. This change also fixes a uint underflow.
marcopeereboom
force-pushed
the
lessthan12
branch
from
5bc80ce to
c93c694
Compare
lukebp
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't be too aggressive with left over time.
During poor network connections (e.g. when using tor) failed votes stack
up over time. That combined with an aggressive end time (originally 1
hour prior to vote being complete) can lead to clustering or failed
votes towards the end.
This adds a new configuration option called --hoursprior. That value
designates the hours to subtract from the end of the voting period and
is set to a default of 12 hours. These extra hours prior to expiration
gives the user some additional margin to correct failures.
This change also fixes a uint underflow.