[cms] Add ProposalBilling request #1137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
degeri
reviewed
Feb 24, 2020
There was a problem hiding this comment.
Looks good. I checked the access controls. Only users with the correct "proposals_owned" value set and admins can query information of a specific proposal.
It shows the invoice details if it has been approved and set as "paid" . Rejected/unreviewed /unpaid invoices cannot be seen. Is that intended ?
alexlyp
force-pushed
the
ayp_proposal_info
branch
from
d11b581 to
f9b9efd
Compare
lukebp
requested changes
Mar 23, 2020
lukebp
approved these changes
Mar 24, 2020
marcopeereboom
suggested changes
Mar 30, 2020
politeiawww/invoices.go
Outdated
| if len(inv.LineItems) < 1 { | ||
| continue | ||
| } | ||
| lineItem := cms.ProposalLineItems{ |
There was a problem hiding this comment.
This conversion should be in a function.
| return nil, err | ||
| } | ||
|
|
||
| dbInvoices := make([]*database.Invoice, 0, len(matching)) |
There was a problem hiding this comment.
This conversion should be in a function.
marcopeereboom
approved these changes
Apr 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires: #1135
This request allows administrators and proposal "owners" to review all
line items that have been billed to the given proposal.
All other private user information for the invoices is hidden (name, address, etc),
so just the raw information about a line item is given.