Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Icon: Add ledger icon. #479

Merged
merged 3 commits into from
May 19, 2023
Merged

Icon: Add ledger icon. #479

merged 3 commits into from
May 19, 2023

Conversation

amass01
Copy link
Member

@amass01 amass01 commented May 19, 2023

Closes #478.

@amass01
Copy link
Member Author

amass01 commented May 19, 2023

Regarding the failing build, currently running yarn prettier does not make any changes.

Also, running yarn lead to the changes pushed in 716165e

@amass01 amass01 changed the title Icon: Add trezor icon. Icon: Add ledger icon. May 19, 2023
tiagoalvesdulce
tiagoalvesdulce approved these changes May 19, 2023
View reviewed changes
Copy link
Member

@tiagoalvesdulce tiagoalvesdulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The command with the --write flag is yarn format. yarn prettier is just a base command for format and test:format.

Everything else LGTM.

@amass01
Copy link
Member Author

amass01 commented May 19, 2023

The command with the --write flag is yarn format. yarn prettier is just a base command for format and test:format.

Everything else LGTM.

Updated, thanks!!

@amass01 amass01 requested a review from tiagoalvesdulce May 19, 2023 19:07
@amass01
Copy link
Member Author

amass01 commented May 19, 2023

gtg 🙏🏽

@tiagoalvesdulce tiagoalvesdulce merged commit d7ca43e into decred:master May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiagoalvesdulce tiagoalvesdulce Awaiting requested review from tiagoalvesdulce

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Icons: Add ledger icon.
2 participants
@amass01 @tiagoalvesdulce