Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameterize #14

Merged
merged 1 commit into from
Aug 14, 2019
Merged

Parameterize #14

merged 1 commit into from
Aug 14, 2019

Conversation

fguisso
Copy link
Member

@fguisso fguisso commented Aug 7, 2019

Add new parameters:

  • testnet, simnet (default: mainnet)
  • certs path
  • macaroon path
  • dcrlnfaucet config path
  • disable generate invoice form
  • disable pay invoice form

resolve #13

Copy link
Member

@matheusd matheusd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the inline comment on network selection.

Also, the params aren't really used anywhere for the moment, so after this PR is in we should add a check to ensure the underlying dcrlnd is running on the specified network.

config.go Show resolved Hide resolved
chainparams.go Outdated Show resolved Hide resolved
faucet.go Outdated Show resolved Hide resolved
faucet.go Show resolved Hide resolved
config.go Outdated Show resolved Hide resolved
@fguisso
Copy link
Member Author

fguisso commented Aug 12, 2019

fix it

config.go Outdated
// Update LndNode using the activeNetParams
cfg.LndNode = "localhost:" + activeNetParams.rpcPort
// If user don't sets the LndNode, then update LndNode
// using the activeNetParams to deafult (localhost:<default_port>).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"If user didn't set the LndNode to connect to then use the default port for the active network (localhost:<default_port>)."

@fguisso
Copy link
Member Author

fguisso commented Aug 13, 2019

I forgot to update sample.conf with new parameters, one minute please! 😮

Copy link
Member

@matheusd matheusd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go. Please squash and provide a proper commit msg.

- `-C or --configfile` to choose config file path
- `--macpath` to choose macaroon path
- `--mainnet` to use the main network
- `--testnet` to use the testnet 3 network
- `--simnet` to use simulation network
- `--tlspath` to choose diferent tls file path
- `--disablegen` to disable generate invoices func
- `--disablepay` to disable payment invoices func

and update the sample-dcrlnfaucet.conf with this new parameters.
@matheusd matheusd merged commit 1b474fa into decred:master Aug 14, 2019
@fguisso fguisso deleted the parameterize branch August 30, 2019 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add new parameters
2 participants