-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parameterize #14
Parameterize #14
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the inline comment on network selection.
Also, the params aren't really used anywhere for the moment, so after this PR is in we should add a check to ensure the underlying dcrlnd is running on the specified network.
fix it |
config.go
Outdated
// Update LndNode using the activeNetParams | ||
cfg.LndNode = "localhost:" + activeNetParams.rpcPort | ||
// If user don't sets the LndNode, then update LndNode | ||
// using the activeNetParams to deafult (localhost:<default_port>). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"If user didn't set the LndNode to connect to then use the default port for the active network (localhost:<default_port>)."
I forgot to update sample.conf with new parameters, one minute please! 😮 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go. Please squash and provide a proper commit msg.
- `-C or --configfile` to choose config file path - `--macpath` to choose macaroon path - `--mainnet` to use the main network - `--testnet` to use the testnet 3 network - `--simnet` to use simulation network - `--tlspath` to choose diferent tls file path - `--disablegen` to disable generate invoices func - `--disablepay` to disable payment invoices func and update the sample-dcrlnfaucet.conf with this new parameters.
Add new parameters:
resolve #13