[transactions] Fix change address for mixed sends #3553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgptr
approved these changes
Sep 13, 2021
bgptr
reviewed
Sep 13, 2021
app/actions/ControlActions.js
Outdated
| @@ -679,6 +704,7 @@ export const constructTransactionAttempt = ( | |||
|
|
|||
| dispatch({ type: CONSTRUCTTX_ATTEMPT, constructTxRequestAttempt: true }); | |||
| try { | |||
| console.log("there?", change); | |||
amass01
reviewed
Sep 13, 2021
scripts/dexsite.js
Outdated
| @@ -3,7 +3,8 @@ var exec = require('child_process').exec; | |||
| var os = require('os'); | |||
|
|
|||
| if (os.type() === 'Linux' || os.type() === 'Darwin' ) | |||
| exec("rm -rf bin/site && cp -R ./node_modules/dcrdex-assets/dexc/site bin/"); | |||
| //exec("rm -rf bin/site && cp -R ./node_modules/dcrdex-assets/dexc/site bin/"); | |||
matheusd
approved these changes
Sep 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3541
Previously change addresses were the same as the sent addresses for mixed sends.
This adds a new action for getting new change addresses. This allows us to get new change addresses without messing with the new address requests which also change various GUI elements (receive account select).