[electron] Enable WebSecurity #3500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vctt94
approved these changes
Jun 10, 2021
alexlyp
approved these changes
Jun 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased on top of #3492This re-disables the remote module on windows and enables the
webSecurityfeature.webSecurityis used to tighten up external requests by enabling same-origin policy and disallowing mixed content.In order to enable this in development mode, external requests are modified in to return a
Allow-Origin: http://localhost:3000header so that the main wallet page loaded via the HMR server is allowed to perform them. Additionally, we fix theOPTIONSrequest performed as a prefetch step to politeia servers when performing aPOSTrequest to always return a 200 response.