Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[redesign] Governance views #3467

Merged
merged 9 commits into from
Jun 4, 2021
Merged

[redesign] Governance views #3467

merged 9 commits into from
Jun 4, 2021

Conversation

bgptr
Copy link
Collaborator

@bgptr bgptr commented May 15, 2021

Closes #3287
Closes #3289

matheusd
matheusd approved these changes Jun 3, 2021
View reviewed changes
Copy link
Member

@matheusd matheusd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

amass01
amass01 approved these changes Jun 3, 2021
View reviewed changes
Copy link
Member

@amass01 amass01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left some minors.

app/actions/GovernanceActions.js Outdated Show resolved Hide resolved
app/components/views/GovernancePage/Blockchain/AgendaOverview/AgendaOverview.jsx Outdated Show resolved Hide resolved
app/components/views/GovernancePage/Blockchain/AgendaOverview/AgendaOverview.module.css Outdated Show resolved Hide resolved
app/components/views/GovernancePage/Proposals/ProposalsListItem/ProposalsListItem.module.css Outdated Show resolved Hide resolved
app/components/views/ProposalDetailsPage/helpers/ProposalCard/ProposalCard.jsx Outdated Show resolved Hide resolved
test/unit/components/views/AgendaDetailsPage/AgendaDetailsPage.spec.js Outdated Show resolved Hide resolved
@bgptr bgptr force-pushed the redesigned-gov branch from 1e9bd0c to 69af9f6 Compare June 3, 2021 18:00
@bgptr bgptr force-pushed the redesigned-gov branch from 69af9f6 to f906441 Compare June 3, 2021 18:01
@bgptr
Copy link
Collaborator Author

bgptr commented Jun 3, 2021

@amassarwi You're right. I've pushed the fix

@amass01
Copy link
Member

amass01 commented Jun 3, 2021

@bgptr awesome, thanks

@alexlyp alexlyp merged commit f42cbb6 into decred:master Jun 4, 2021
@bgptr bgptr deleted the redesigned-gov branch August 27, 2021 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amass01 amass01 amass01 approved these changes

@alexlyp alexlyp alexlyp approved these changes

@matheusd matheusd matheusd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Governance-Consensus Changes update Governance-Proposals update
4 participants
@bgptr @amass01 @matheusd @alexlyp