remove unlock wallet #3424
Merged
remove unlock wallet #3424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matheusd
reviewed
Apr 26, 2021
|
This also affects LN wallet creation when creating a new account is chosen (vs using an existing account). |
vctt94
force-pushed
the
lock-acct-after-initial-setup
branch
from
695b77b to
cf06cd1
Compare
|
You are right. This should fix it now |
matheusd
reviewed
Apr 27, 2021
|
RIght, I change them to use the getNextAccountAttempt, instead. Thanks |
matheusd
approved these changes
Apr 27, 2021
alexlyp
pushed a commit
that referenced
this pull request
Apr 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3420.
The unlock is not necessary as we sent the passphrase through the grpc request so dcrwallet can make the unlock.