[various] Disable buttons when mixing, autobuyer or purchase tickets running #3231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amass01
approved these changes
Feb 16, 2021
| @@ -36,7 +36,9 @@ | |||
| background-image: var(--menu-mixer-icon); | |||
| background-size: 16px 16px; | |||
| cursor: pointer; | |||
| animation: spin 1s linear infinite; | |||
| /* XXX Need a different animation method due to performance of this | |||
There was a problem hiding this comment.
Maybe a different .gif ? worth creating a separate issue I would say.
There was a problem hiding this comment.
Yah I'll leave this then call it out in an issue. There's this and the pending indicators on transactions on the overview that I've noticed be huge perf hogs.
| @@ -31,6 +32,19 @@ const TicketAutoBuyerForm = ({ | |||
| {isTicketAutoBuyerEnabled ? ( | |||
| <AutoBuyerSwitch enabled onClick={onDisableTicketAutoBuyer} /> | |||
| ) : ( | |||
| getRunningIndicator ? | |||
|
|
|||
amass01
approved these changes
Feb 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid issues and to help UX a bit, we should be disallowing various features to be run at the same time.
Currently when mixer, autobuyer or ticket purchases are running we disable all the other buttons as well as the send transactions.
I've also included a change to the sidebar running indicator css to remove the animation that has been shown to be really bad for performance.