-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add v1.6.0 release notes #3048
Add v1.6.0 release notes #3048
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typography for the release notes page seems pretty broken.
A quick & dirty fix to improve it a bit would be adding the following in GetStarted.module.css
:
.releaseNotesText p,
.releaseNotesText ul,
.releaseNotesText ol,
.releaseNotesText h1,
.releaseNotesText h2,
.releaseNotesText h3,
.releaseNotesText h4 {
margin-bottom: 1em;
}
Also, there are some .yarncache files in the commit.
|
||
* We have added a new menu item that covers Privacy and Security tools. | ||
Users should go there to 'enable' privacy on their wallets. This enabling | ||
process is not done automatically yet, mostly to required user |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"mostly due to"
* The new accountless VSP ticket purchasing process has been added as well. | ||
Now there is no need to 'link' a VSP by API key. Users may now simply go | ||
to the tickets page, select the VSP they'd like to use and the number of | ||
ticket to purchase. If privacy is enabled, the process of purchasing a ticket |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
number of tickets
to the tickets page, select the VSP they'd like to use and the number of | ||
ticket to purchase. If privacy is enabled, the process of purchasing a ticket | ||
requires there to be a successful mix to occur. This can cause the ticket | ||
purchasing process take about 10 minutes to complete. If successful the mixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"10 minutes to complete" seems too optimistic to list here (though I guess it should be the average time assuming users join the sessions at random times and only require a single session).
Maybe it would be better something along the lines of:
"... requires there to be a successful mix to occur. Mix sessions happen every 20 minutes and participating in a single session is usually (though not always) sufficient."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
Maybe unrelated to the changes in this PR - a "Newer Version" link is displayed at the top of the 1.6.0 release note, even though it is the newest.
-
Some image options. I believe @behindtext and @linnutee agreed to go with the third option, and tbh I think I prefer that one too. Beware that these are ~8MB each, so probably need some compression.
tickets to purchase. If privacy is enabled, the process of purchasing a | ||
ticket requires there to be a successful mix to occur. Mix sessions happen | ||
every 20 minutes and participating in a single session is usually (though not | ||
always) sufficient. If successful the mixed split ticket funding transaction, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest some extra commas and a couple less words in this list:
If successful, the mixed split ticket funding transaction, the ticket, and the ticket's fee, should all be seen on the overview.
Co-authored-by: Jamie Holdstock <jam.jar69@gmail.com>
Co-authored-by: Jamie Holdstock <jam.jar69@gmail.com>
No description provided.