Add running indicator on cant close selector #3005
Conversation
|
Hrm overall it's OK. But the modal that I'm seeing when the mixer is running references the auto-buyer. Can we do specific modal title/text depending on what's running? |
| <div className={style.confirmContent}> | ||
| <T | ||
| id="account.mixer.running.message" | ||
| m="Account mixer is running. If closed no more dcr will be mixed. |
There was a problem hiding this comment.
no more dcr will be mixed
Is this really the only consequence if Decrediton is closed while the mixer is running? I thought there was more at risk.
Regardless, I suggest rewording to:
Account mixer is currently running. Ongoing mixes will be cancelled and no more Decred will be mixed if Decrediton is closed now.
| { | ||
| <T | ||
| id="account.mixer.running.btnConfirm" | ||
| m="Confirm" |
There was a problem hiding this comment.
Rather than Confirm, lets explicitly say this button will Close Decrediton
| { | ||
| <T | ||
| id="tickets.purchasing.confirmModal.btnConfirm" | ||
| m="Confirm" |
| <div className={style.confirmContent}> | ||
| <T | ||
| id="tickets.purchasing.message" | ||
| m="Decrediton is finishing the purchasing ticket process and should wait." |
There was a problem hiding this comment.
Decrediton is still finalizing ticket purchases. Tickets may not be registered with the VSP if Decrediton is closed now, which can result in missed votes.
|
Works well, just a couple of suggested changes to strings. |
This PR adds the running indicator selector into the can't close selector.
This way decrediton will not allowed to be closed if it is perfoming any action represented by the running indicator: Ticket auto buyer, running mixer or purchasing tickets